Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-isomorphic-tools #108

Merged
merged 1 commit into from
Aug 17, 2015
Merged

webpack-isomorphic-tools #108

merged 1 commit into from
Aug 17, 2015

Conversation

catamphetamine
Copy link
Contributor

Seems working for me. You can also check if it works on your machine.

@catamphetamine catamphetamine mentioned this pull request Aug 10, 2015
@erikras
Copy link
Owner

erikras commented Aug 10, 2015

I look forward to checking this out.

@bdefore
Copy link
Collaborator

bdefore commented Aug 11, 2015

Do these changes preserve support for local css and its source mapping?

@catamphetamine
Copy link
Contributor Author

@bdefore I'm not so keen about the technical terms you used so I currently don't know how to answer your question. You can check by yourself though if you want. You can do so by cloning this fork and switching to webpack-isomorphic-tools branch and then running it the way you want.

@bdefore
Copy link
Collaborator

bdefore commented Aug 11, 2015

@halt-hammerzeit i just gave it a test and it does work with styles, they are mapped properly and hot reload too. i'm liking this PR!

@catamphetamine
Copy link
Contributor Author

@bdefore good)

@leonli
Copy link
Contributor

leonli commented Aug 14, 2015

👍

@catamphetamine
Copy link
Contributor Author

I'll make an additional pull request later today to update webpack-isomorphic-tools to the newest version (0.8.0)

@catamphetamine
Copy link
Contributor Author

@erikras done:
#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants