update universal router getFetchState #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loop through all DecoratedComponent instances when looking for static fetchData method. This was needed when I had more than one decorator on a component (assuming my additional decorators used the same 'DecoratedComponent' static name. Also set default object for component param to avoid repetitive undefined checks.
erikras
added a commit
that referenced
this pull request
Jul 30, 2015
update universal router getFetchState
erikras
pushed a commit
that referenced
this pull request
Jul 30, 2015
…d to use url-loader to encode small images.
erikras
pushed a commit
that referenced
this pull request
Jul 31, 2015
* master: (21 commits) improved syntax for including styles fixed #77 added apology for #60 in the README linted url-loader fix for images switched back to file-loader to avoid error from requireServerImage() fixes #39 Works on mac now Added better-npm-run to allow setting env-vars on all platforms fixed cat pic on server render minor grammar and js style tweak to README added url-loader to production webpack, too merged PR #67. lint-corrected merge. added obligatory cat pic. changed to use url-loader to encode small images. made pass lint incorporated PR #67 and added some comments to promise chaining in createTransitionHook() util import should be in single line. correct the ， to , sorry for my keyboard. remove a space :P update README. correct the util error :P add the image server render example to the logo.png. ...
erikras
pushed a commit
that referenced
this pull request
Jul 31, 2015
* master: (32 commits) fixed npm script problem and upgraded redux-form added form support with redux-form npm knows how to prefix binaries oops, left in debugger call improved syntax for including styles fixed #77 added apology for #60 in the README linted url-loader fix for images switched back to file-loader to avoid error from requireServerImage() fixes #39 Works on mac now Added better-npm-run to allow setting env-vars on all platforms fixed cat pic on server render minor grammar and js style tweak to README added url-loader to production webpack, too merged PR #67. lint-corrected merge. added obligatory cat pic. changed to use url-loader to encode small images. made pass lint incorporated PR #67 and added some comments to promise chaining in createTransitionHook() work on forms work on forms ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop through all DecoratedComponent instances when looking for static fetchData method. This was needed when I had more than one decorator on a component (assuming my additional decorators used the same 'DecoratedComponent' static name.
Also set default object for component param to avoid repetitive undefined checks.