Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Python 3.8 compatibility #295

Open
HaleTom opened this issue Dec 11, 2019 · 5 comments
Open

Release for Python 3.8 compatibility #295

HaleTom opened this issue Dec 11, 2019 · 5 comments

Comments

@HaleTom
Copy link

HaleTom commented Dec 11, 2019

% ponysay foo
/usr/bin/ponysay/backend.py:294: SyntaxWarning: "is not" with a literal. Did you mean "!="?
/usr/bin/ponysay/backend.py:294: SyntaxWarning: "is not" with a literal. Did you mean "!="?
 _______________
< foo           >
 ---------------
                  \
                   \
                    \
                     \  ▄▄
    ▄▄          ▄▄  ▄▄▄███▄
   ███▄▄▄▄▄▄▄  ████▄▄▄▄▄█▄█▄▄ ▄▄▄▄▄
@HaleTom
Copy link
Author

HaleTom commented Dec 11, 2019

Oops, was resolved by 69c23e3.

My google-fu was weak.

@HaleTom HaleTom closed this as completed Dec 11, 2019
@HaleTom
Copy link
Author

HaleTom commented Dec 11, 2019

Would you consider another release given this makes things very ugly (and the last was 2017?)

@HaleTom HaleTom reopened this Dec 11, 2019
@HaleTom HaleTom changed the title backend.py:294: SyntaxWarning: "is not" with a literal. Did you mean "!="? Release for Python 3.8 compatibility Dec 11, 2019
@JotaRandom
Copy link
Collaborator

JotaRandom commented Jan 10, 2020

There is #254 and #263 that i want first to be adressed before doing a new release

Any patch for those is welcome

@victordidenko
Copy link

To anyone with MacOS, stumbled upon this, you can temporarily fix your Homebrew package with following:

cd $(dirname $(readlink -f $(which ponysay)))
unzip ponysay -d source
vi +294 source/backend.py

replace is not with !=, like here

head -1 ponysay

note first line, in my case this line is

#!/usr/bin/env /usr/local/opt/python@3.8/bin/python3

python3 -m zipapp source -o ponysay_fixed -p "/usr/bin/env /usr/local/opt/python@3.8/bin/python3"

in -p argument set interpreter from previous step, without starting #!
And finally, replace main ponysay link to fixed file:

cd $(dirname $(which ponysay))
ln -sf ../Cellar/ponysay/3.0.3_4/bin/ponysay_fixed ponysay

(make sure you point symlink correctly)

@victordidenko
Copy link

victordidenko commented Jun 3, 2020

As I see, issue was fixed in new Homebrew package:

ponysay 3.0.3_4 -> 3.0.3_5

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants