Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia files .jl no longer allowed? #881

Closed
1 task done
kellertuer opened this issue Aug 3, 2024 · 2 comments
Closed
1 task done

Julia files .jl no longer allowed? #881

kellertuer opened this issue Aug 3, 2024 · 2 comments

Comments

@kellertuer
Copy link
Contributor

Check for existing issues

  • Completed

Environment

Mac OS, vale 3.7.0 via homebrew

Describe the bug / provide steps to reproduce it

I just wanted to get back to vale (after not having used it for a while). I have it set up to check my Jluia files (.jl) and have not changed the config. However, vale now reports

❯ vale .
unsupported extension: '.jl'

For my current config see https://github.com/JuliaManifolds/Manopt.jl/blob/kellertuer/modularize-docstrings/.vale.ini

Did I miss some change that might have cause that?
What do I have to do to get them back as allowed ones?
It would be nice to have a good place to see such breaking changes.

@jdkato
Copy link
Member

jdkato commented Aug 25, 2024

This will be fixed in the next release (as should #838).

Vale now uses Tree-sitter instead of regex to parse source code. If you find that too little is linted now for your taste, feel free to contribute additional queries (currently just block_comment and line_comment are extracted).

@jdkato jdkato closed this as completed Aug 25, 2024
@kellertuer
Copy link
Contributor Author

thanks
I will check. My main reason I use it for is actally doc strings (that is blocks of strings upfront a function). So if they are not extracted I might check that and propose a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants