Incorrect check for a non-compliant Array.prototype.splice implementation #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on that was causing a shim to be applied to ES5-compliant browsers instead of applying it to buggy/incorrectly implemented ones
BendingBender
changed the title
|
Thanks, this definitely makes tests pass in Safari 5.0, and leaves them passing in conforming implementations. Good catch! |
ljharb
added a commit
that referenced
this pull request
Dec 19, 2014
…ns-undefined-safari-5_0 Fix check for non-compliant `Array#splice`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a check for a non-compliant Array.prototype.splice implementation that was causing a shim to be applied to ES5-compliant browsers instead of applying it to buggy/incorrectly implemented ones