Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fast-glob with tinyglobby in Vite #106

Closed
benmccann opened this issue Sep 8, 2024 · 8 comments
Closed

Replace fast-glob with tinyglobby in Vite #106

benmccann opened this issue Sep 8, 2024 · 8 comments

Comments

@benmccann
Copy link

benmccann commented Sep 8, 2024

I can offer a code review for this one and @bluwy also mentioned being supportive of the idea. It would be a good idea to do somewhat soon while 6.0 is in pre-release so that we can do it as part of a major release. Vitest, vitepress, vite-plugin-pwa, and other Vite-affiliated projects have already moved

See SuperchupuDev/tinyglobby#28 for additional details on migrating

@bluwy
Copy link

bluwy commented Sep 9, 2024

It would be best if we check with the Vite maintainers first, maybe in it's server's contributing channel. I don't have the final say for changes like this.

@ziebam
Copy link

ziebam commented Sep 10, 2024

I've started some work on this locally, waiting for further discussion with vite maintainers and tinyglobby dependencies before pushing though.

@benmccann
Copy link
Author

Confirmed on the Vite Discord that other maintainers are also supportive. They pointed out though that we'd also need to migrate @rollup/plugin-dynamic-import-vars to get the full benefit, so I've filed an issue for it as well: #109

@SuperchupuDev
Copy link

the new tinyglobby version is out which added support for everything needed to migrate

@benmccann
Copy link
Author

I've sent a PR to switch @rollup/plugin-dynamic-import-vars to tinyglobby

@ziebam
Copy link

ziebam commented Oct 1, 2024

@benmccann We caught a bug on 0.2.7 while migrating to tinyglobby in Vite, make sure to bump the version to 0.2.8 in your @rollup/plugin-dynamic-import-vars PR too.

https://github.com/vitejs/vite/pull/18243 – migration in Vite itself.

@benmccann
Copy link
Author

Thanks. Updated!

@benmccann
Copy link
Author

completed in vitejs/vite#18243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants