Bank scrapers not updated automatically

[ifeins]

If someone updates the israeli-bank-scrapers npm module then it doesn't automatically gets reflected in the ynab updater because the package.json points to a specific version.

Even if the package.json pointed to the latest version (e.g. israeli-bank-scrapers@latest) then if someone ran npm install a while ago on israeli-ynab-updater then he'll have to remember to run npm install to get the latest bank scrapers.

[eshaham]

@ifeins I think this is how npm updating works.
You need to proactively call npm install after you update current repo from git to make sure all the dependencies are fetched.
^0.5.3 is actually not referencing a specific version, but any minor version following it.
So if at the time you run npm install the dependent module has a higher minor version, say 0.6.1, that version will actually get installed. see here.
Regardless, I don't like using @latest in my dependencies, as it might fetch breaking changes.

[ifeins]

@eshaham Is that true even when package-lock.json has a specific version of israeli-bank-scrapers?

[eshaham]

Actually @ifeins, you are right.
Since this repo has the package lock file checked in, it will force using the same version until someone runs npm update and checks in the update package lock file.
But that should also apply if we had @latest used for a dependency.

[ifeins]

@eshaham Got it, I'll put some more thought into it and see if somethings comes up.

[eshaham]

@ifeins let me know if we can close this issue

[ifeins]

@eshaham It's still an issue, don't have any solve yet.

[esakal]

@eshaham are you planning to deploy this app as a node standalone application?