-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete mediated invitation type? #223
Comments
Can't see this namespace in linked fragment. Is this issue still valid? |
Here's a persistent link: MongooseIM/apps/ejabberd/src/mod_muc_room.erl Line 3999 in d6bb90c
|
👍 for removing this element. We can check if popular XMPP clients need it (e.g. Pidgin or Adium) and even if at some point someone would report that mediated inv. do not work with specific client, then we could always revert the change or recommend alternative. |
I removed it; Pidgin's docs point to XEP-0045 site, and also in my opinion its better to stick to the protocol |
Removed obsolete namespace from mediated invitation stanza
I'm not sure but it seems that
<x xmlns="jabber:x:conference"/>
(see mod_muc_room.erl) is obsolete, probably a leftover from pre-XMPP Groupchat 1.0 specification.XEP-0045 defines mediated invitation as containing
<x xmlns="http://jabber.org/protocol/muc#user"/>
which is also included in the message sent by MongooseIM.Maybe we should remove the obsolete element? Unless some client apps rely on it...
The text was updated successfully, but these errors were encountered: