Obsolete mediated invitation type?

[erszcz]

I'm not sure but it seems that <x xmlns="jabber:x:conference"/> (see mod_muc_room.erl) is obsolete, probably a leftover from pre-XMPP Groupchat 1.0 specification.
XEP-0045 defines mediated invitation as containing <x xmlns="http://jabber.org/protocol/muc#user"/> which is also included in the message sent by MongooseIM.
Maybe we should remove the obsolete element? Unless some client apps rely on it...

[fenek]

Can't see this namespace in linked fragment. Is this issue still valid?

[erszcz]

Here's a persistent link:

MongooseIM/apps/ejabberd/src/mod_muc_room.erl

Line 3999 in d6bb90c

attrs = [{<<"xmlns">>, ?NS_XCONFERENCE}, {<<"jid">>, BRoomJID}],

[fenek]

👍 for removing this element. We can check if popular XMPP clients need it (e.g. Pidgin or Adium) and even if at some point someone would report that mediated inv. do not work with specific client, then we could always revert the change or recommend alternative.

[ludwikbukowski]

I removed it; Pidgin's docs point to XEP-0045 site, and also in my opinion its better to stick to the protocol