-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no-deprecated-api support removed api #240
Conversation
fa74be9
to
74ab0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I assume the error is the missing global? I wonder if there is a way to have this error without the global being defined?
@@ -745,6 +746,8 @@ module.exports = { | |||
messages: { | |||
deprecated: | |||
"{{name}} was deprecated since v{{version}}{{replace}}.", | |||
removed: | |||
"{{name}} was deprecated since v{{version}}, and removed in v{{removed}}.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be worth including replace
here still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can add it in another PR.
74ab0d3
to
42ac0a6
Compare
Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
c0c78f1
to
009f422
Compare
No description provided.