Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression when updating to node: ^23 (no-unpublished-require) #369

Closed
scagood opened this issue Oct 21, 2024 · 1 comment · Fixed by #368
Closed

Regression when updating to node: ^23 (no-unpublished-require) #369

scagood opened this issue Oct 21, 2024 · 1 comment · Fixed by #368
Labels

Comments

@scagood
Copy link

scagood commented Oct 21, 2024

We have a regression in node: ^23

Specifically this test is failing

{
filename: fixture("issue48n/test.js"),
code: "require('./');",
},


Example action:

https://github.com/eslint-community/eslint-plugin-n/actions/runs/11448831559/job/31853177596?pr=368

  4) no-unpublished-require
       valid
         require('./');:

      AssertionError [ERR_ASSERTION]: Should have no errors but had 1: [
  {
    ruleId: 'rule-to-test/no-unpublished-require',
    severity: 1,
    message: '"./" is not published.',
    line: 1,
    column: 9,
    nodeType: 'Literal',
    messageId: 'notPublished',
    endLine: 1,
    endColumn: 13
  }
]

1 !== 0

      + expected - actual

      -1
      +0
      
      at testValidTemplate (node_modules/eslint/lib/rule-tester/rule-tester.js:925:20)
      at Context.<anonymous> (node_modules/eslint/lib/rule-tester/rule-tester.js:1274:37)
      at process.processImmediate (node:internal/timers:511:21)
@scagood scagood linked a pull request Oct 22, 2024 that will close this issue
@scagood scagood linked a pull request Oct 22, 2024 that will close this issue
@scagood
Copy link
Author

scagood commented Oct 24, 2024

Original comment from @aladdin-add (#368 (comment))

related: nodejs/node#54224

and it will be reverted in nodejs/node#55414.

@scagood scagood closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant