Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove name from eslintrc config; fixes #489 #490

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 19, 2024

What is the purpose of this pull request?

  • Bug fix

What changes did you make? (Give an overview)

Remove name from eslintrc config. It is only ok on the flat config.

Fixes #489.

@brettz9
Copy link
Member Author

brettz9 commented Jul 19, 2024

@voxpelli : Sorry, if you're free to take a quick look, I shouldn't have included name on the eslintrc recommended config (just the flat one). This fixes that...

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (5bd794c).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       660   +11     
  Branches       250       246    -4     
=========================================
+ Hits           649       660   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@voxpelli voxpelli merged commit c011a1a into eslint-community:main Jul 20, 2024
17 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9 brettz9 deleted the name-fix branch July 20, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected top-level property "name" with ESLint 8
2 participants