feat(prefer-await-to-then): ignore constructor scope unless with strict option
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trict` option; fixes eslint-community#436
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 24 -1
Lines 649 668 +19
Branches 250 251 +1
=========================================
+ Hits 649 668 +19 ☔ View full report in Codecov by Sentry. |
voxpelli
pushed a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [7.1.0](v7.0.0...v7.1.0) (2024-08-06) ### 🌟 Features * **`catch-or-return`, `prefer-await-to-then`:** do not report Cypress commands ([#495](#495)) ([943f162](943f162)) * **`prefer-await-to-then`:** ignore constructor scope unless with `strict` option ([#496](#496)) ([7bffb7a](7bffb7a)) * new rule `spec-only` to check for non-spec Promise methods ([#502](#502)) ([d6e9de1](d6e9de1)) ### 📚 Documentation * fixes the CI readme badge ([#511](#511)) ([030a3be](030a3be)) * supply missing docs ([#503](#503)) ([602d825](602d825)) ### 🧹 Chores * bump dev dependencies ([#483](#483)) ([197ae4e](197ae4e)) * **deps-dev:** bump husky from 9.1.1 to 9.1.2 ([#516](#516)) ([ab8e7a0](ab8e7a0)) * file extension missing ([#519](#519)) ([94c9834](94c9834)) * fix format.yml ([#507](#507)) ([948c097](948c097)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Ignores constructor scope in
prefer-await-to-thenwhen reporting on use ofthen(unless thestrictoption is enabled).