Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap release process to release-please #506

Closed
voxpelli opened this issue Jul 24, 2024 · 7 comments · Fixed by #508
Closed

Swap release process to release-please #506

voxpelli opened this issue Jul 24, 2024 · 7 comments · Fixed by #508
Assignees
@voxpelli

Comments

@voxpelli
Copy link
Member

I would personally be in favor of switching to a release please flow, like in eslint-community/eslint-plugin-n#305, as that catches errors like this before release

This would help catch release errors like #484 (comment) before they actually get released
@voxpelli
Copy link
Member Author

Thoughts @scagood @aladdin-add @brettz9?

@brettz9
Copy link
Member

brettz9 commented Jul 24, 2024

Looks all right to me...

@scagood
Copy link
Contributor

scagood commented Jul 24, 2024

I do much prefer release-please as:

  1. It allows you to see the change logs in the PR description
  2. The package version is always correct in the package.json
  3. It allows for a more transparent release process

(Also, its just personal comfort 😂)

It does have some down sides, such as merge commits occasionally create double entries in the change log.

@ota-meshi
Copy link
Member

Between release-please and semantic-release, I personally prefer release-please. Because we can control the release timing.

@ota-meshi ota-meshi mentioned this issue Jul 24, 2024
Merged
1 task
@voxpelli
Copy link
Member Author

It does have some down sides, such as merge commits occasionally create double entries in the change log.

Yeah, one should preferably only do squash (or rebase commits) with it

@voxpelli voxpelli self-assigned this Jul 24, 2024
@ota-meshi
Copy link
Member

Currently, it appears that only squash merging is allowed for this repository.

voxpelli added a commit that referenced this issue Jul 24, 2024
@voxpelli
ci: swap release process to release-please
8c1211f 
Fixes #506
@voxpelli voxpelli mentioned this issue Jul 24, 2024
Merged
voxpelli added a commit that referenced this issue Jul 24, 2024
@voxpelli
ci: swap release process to release-please
9622c9e 
Fixes #506
@voxpelli
Copy link
Member Author

Currently, it appears that only squash merging is allowed for this repository.

That's good 👍

@voxpelli voxpelli mentioned this issue Jul 24, 2024
Merged
voxpelli added a commit that referenced this issue Jul 24, 2024
@voxpelli
ci: swap release process to release-please (#508)
e1ce2ad 
**What is the purpose of this pull request?**

To improve the release process by swapping to release-please. Fixes #506

**What changes did you make? (Give an overview)**

Removed `cycjimmy/semantic-release-action` and added
`googleapis/release-please-action`
voxpelli added a commit that referenced this issue Jul 24, 2024
@voxpelli
ci: add pr title format validation (#509)
1e13293 
**What is the purpose of this pull request?**

To assist #508 / #506 by ensuring that PR-title's are always valid
conventional commit format before merging

**What changes did you make? (Give an overview)**

Added a pinned
[mtfoley/pr-compliance-action](https://github.com/mtfoley/pr-compliance-action)
similar to what I use at eg. neostandard:
https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml
@voxpelli voxpelli mentioned this issue Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voxpelli voxpelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: swap release process to release-please eslint-community/eslint-plugin-promise
4 participants
@brettz9 @voxpelli @scagood @ota-meshi