Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve detect-child-process rule #108

Merged
merged 3 commits into from
Jan 26, 2023
Merged

feat: improve detect-child-process rule #108

merged 3 commits into from
Jan 26, 2023

Conversation

ota-meshi
Copy link
Member

close #104

This PR improves the detect-child-process rule with the following changes:

  • Changed to check module imports as well.
  • Changed to check import of node:child_process.
  • Changed to report immediate calls like require('child_process').exec(c).
  • Changed to report exec(c) calls with destructuring.
  • Changed to not report traceable require('child_process').

@ota-meshi ota-meshi mentioned this pull request Jan 12, 2023
Merged
@ota-meshi ota-meshi requested a review from a team January 16, 2023 00:53
nzakas
nzakas approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 64ae529 into main Jan 26, 2023
@nzakas nzakas deleted the improve-detect-child-process branch January 26, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve detect-child-process rule
2 participants
@ota-meshi @nzakas