-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for detect-new-buffer
is missing
#25
Comments
dskrvk
changed the title
Documentation for is missing
Documentation for Nov 30, 2017
detect-new-buffer
is missing
Summary
Still relevant? Next steps
|
I can pick this one once we start to fix things. |
Is the reason this is dangerous nodejs/node#4660 ? |
@hedtkeCqse yes, that's correct. I'll add that to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was added in #7 but somehow got removed later. In addition, that original description was a bit terse - can you include an explanation and/or a link as to why this is bad?
E.g.
amqplib
requires using a Buffer ctor with an arbitrary String argument to send messages. I could add a suppression, but want to understand the intent of this check.The text was updated successfully, but these errors were encountered: