fix(no-expression-statements): ignore Promise<void> when ignoreVoid is set
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “Status: Merge Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Status: Hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @RebeccaStevens and the rest of your teammates on |
Merge activity
|
RebeccaStevens
force-pushed
the
08-26-fix_no-expression-statements_ignore_promise_void_when_ignorevoid_is_set
branch
from
c047578 to
2e1a992
Compare
graphite-app
bot
deleted the
08-26-fix_no-expression-statements_ignore_promise_void_when_ignorevoid_is_set
branch
github-actions bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
## [7.0.2](v7.0.1...v7.0.2) (2024-08-26) ### Bug Fixes * **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](#866)) ([2e1a992](2e1a992))
|
🎉 This issue has been resolved in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 26, 2024
##### [v7.0.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#702-2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992))
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 16, 2024
##### [v7.0.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#702-2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992)) ##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 17, 2024
##### [v7.0.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#702-2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992)) ##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 17, 2024
##### [v7.0.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#702-2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992)) ##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 17, 2024
##### [v7.0.2](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#702-2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992)) ##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Oct 20, 2024
##### [v7.1.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#710-2024-10-20) ##### Features - new rule no-class-inheritance ([#890](eslint-functional/eslint-plugin-functional#890)) ([53df2fd](eslint-functional/eslint-plugin-functional@53df2fd)), closes [#886](eslint-functional/eslint-plugin-functional#886) #### [7.0.3](eslint-functional/eslint-plugin-functional@v7.0.2...v7.0.3) (2024-10-20) ##### Bug Fixes - ensure default options are applied ([#889](eslint-functional/eslint-plugin-functional#889)) ([5b57cd2](eslint-functional/eslint-plugin-functional@5b57cd2)) - **functional-parameters:** default options not being applied to option overrides ([#888](eslint-functional/eslint-plugin-functional#888)) ([06f2b80](eslint-functional/eslint-plugin-functional@06f2b80)) #### [7.0.2](eslint-functional/eslint-plugin-functional@v7.0.1...v7.0.2) (2024-08-26) ##### Bug Fixes - **no-expression-statements:** ignore `Promise<void>` when `ignoreVoid` is set ([#866](eslint-functional/eslint-plugin-functional#866)) ([2e1a992](eslint-functional/eslint-plugin-functional@2e1a992)) #### [7.0.1](eslint-functional/eslint-plugin-functional@v7.0.0...v7.0.1) (2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.