Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert source code into TypeScript #437

Closed
g-plane opened this issue Apr 3, 2020 · 6 comments
Closed

Convert source code into TypeScript #437

g-plane opened this issue Apr 3, 2020 · 6 comments

Comments

@g-plane
Copy link
Member

g-plane commented Apr 3, 2020

Should we consider converting the source code of this project into TypeScript? We can leverage type checking with TypeScript. Also, .d.ts files can be generated for downstream users when compiling.

It may take long time to do this coversion, so we can enable allowJs and start progressive conversion.

@kaicataldo
Copy link
Member

I'm generally 👎 for this proposal, particularly since we're not using TypeScript in ESLint core.

Relevant PR: eslint/eslint#12082

@nzakas
Copy link
Member

nzakas commented Apr 3, 2020

I agree with @kaicataldo. I’d like ESLint to remain pure JavaScript to enable us to best test ESLint on itself.

@g-plane
Copy link
Member Author

g-plane commented Apr 4, 2020

Hey, this is espree, not ESLint.

@nzakas
Copy link
Member

nzakas commented Apr 4, 2020

Espree is part of the ESLint project.

@simonbuchan
Copy link

Note that webpack is using typescript in --checkJs to get at least some typechecking without needing a build step. Not sure if that matters to you.

@nzakas
Copy link
Member

nzakas commented Jul 28, 2020

We aren't going to move forward with this, so closing.

@nzakas nzakas closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants