From c039ea8797c4ff4f2d333458bf89a25fa634367e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1niel=20Buga?= Date: Thu, 24 Oct 2024 07:56:27 +0200 Subject: [PATCH] Review changes Co-authored-by: Dominic Fischer <14130965+Dominaezzz@users.noreply.github.com> --- esp-hal/CHANGELOG.md | 2 +- esp-hal/src/gpio/interconnect.rs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/esp-hal/CHANGELOG.md b/esp-hal/CHANGELOG.md index 8f631d0753d..5a9614e5ba6 100644 --- a/esp-hal/CHANGELOG.md +++ b/esp-hal/CHANGELOG.md @@ -50,7 +50,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed the pin type parameters from `parl_io::{TxOneBit, TxTwoBits, TxFourBits, TxEightBits, TxSixteenBits}` (#2388) - Removed the pin type parameters from `parl_io::{RxOneBit, RxTwoBits, RxFourBits, RxEightBits, RxSixteenBits}` (#2388) - Removed the pin type parameters from `lcd_cam::lcd::i8080::{TxEightBits, TxSixteenBits}` (#2388) -- Removed the pin type parameters from `lcd_cam::lcd::cam::{RxEightBits, RxSixteenBits}` (#2388) +- Removed the pin type parameters from `lcd_cam::cam::{RxEightBits, RxSixteenBits}` (#2388) ## [0.21.1] diff --git a/esp-hal/src/gpio/interconnect.rs b/esp-hal/src/gpio/interconnect.rs index 8f949a11896..f0aa86c09a2 100644 --- a/esp-hal/src/gpio/interconnect.rs +++ b/esp-hal/src/gpio/interconnect.rs @@ -26,14 +26,12 @@ use crate::{ /// /// Peripheral drivers are encouraged to accept types that implement this and /// [`PeripheralOutput`] as arguments instead of pin types. -#[doc(hidden)] pub trait PeripheralInput: Into + 'static {} /// A signal that can be connected to a peripheral input and/or output. /// /// Peripheral drivers are encouraged to accept types that implement this and /// [`PeripheralInput`] as arguments instead of pin types. -#[doc(hidden)] pub trait PeripheralOutput: Into + 'static {} impl PeripheralInput for P {} @@ -282,7 +280,7 @@ impl OutputSignal { impl OutputSignal { /// Connect the pin to a peripheral input signal. /// - /// Since there can only be one input signal connected to a peripheral at a + /// Since there can only be one signal connected to a peripheral input at a /// time, this function will disconnect any previously connected input /// signals. fn connect_input_to_peripheral(&mut self, signal: gpio::InputSignal, _: private::Internal) {