-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the usage of floats #108
Comments
note: the upcoming LEDC implementation is currently also using floats |
I did say to @JurajSadel that we can not worry about the floats right now, just for the sake of getting things completed and merged. If you have a problem with this please feel free to say so though, doesn't really make a difference to me. |
No problem with that - we can replace the floats in one go later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we use floats in one place:
esp-hal/esp-hal-common/src/timer.rs
Lines 226 to 229 in 907d43e
If possible we should remove that since it adds 2k of code (optimized) for ESP32-C3:
The text was updated successfully, but these errors were encountered: