From 386b357157a239ff73fc06dc909fc45e38ebfabf Mon Sep 17 00:00:00 2001 From: liebman Date: Sun, 26 May 2024 08:12:46 -0700 Subject: [PATCH 1/5] esp-hal: rmt: make ChannelCreator public --- esp-hal/src/rmt.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/esp-hal/src/rmt.rs b/esp-hal/src/rmt.rs index 6834acf80b5..728f522fe0d 100644 --- a/esp-hal/src/rmt.rs +++ b/esp-hal/src/rmt.rs @@ -209,6 +209,7 @@ pub struct RxChannelConfig { } pub use impl_for_chip::Rmt; +pub use impl_for_chip::ChannelCreator; #[cfg(feature = "async")] use self::asynch::{RxChannelAsync, TxChannelAsync}; @@ -949,6 +950,8 @@ mod impl_for_chip { } } + /// RMT Channel Creator + #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, From 83e1b0d89d3df899b084a36ed908b8f6ad24cb0e Mon Sep 17 00:00:00 2001 From: liebman Date: Sun, 26 May 2024 08:17:38 -0700 Subject: [PATCH 2/5] esp-hal: rmt: fmt-packages --- esp-hal/src/rmt.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/esp-hal/src/rmt.rs b/esp-hal/src/rmt.rs index 728f522fe0d..72901ad74ed 100644 --- a/esp-hal/src/rmt.rs +++ b/esp-hal/src/rmt.rs @@ -208,8 +208,7 @@ pub struct RxChannelConfig { pub idle_threshold: u16, } -pub use impl_for_chip::Rmt; -pub use impl_for_chip::ChannelCreator; +pub use impl_for_chip::{ChannelCreator, Rmt}; #[cfg(feature = "async")] use self::asynch::{RxChannelAsync, TxChannelAsync}; From 2ffbfaabf0120bd00584a9ddd075612d91e4e507 Mon Sep 17 00:00:00 2001 From: liebman Date: Sun, 26 May 2024 08:23:08 -0700 Subject: [PATCH 3/5] esp-hal: rmt: fix ChannelCreator missing docs for other (non-esp32s3) implementation --- esp-hal/src/rmt.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/esp-hal/src/rmt.rs b/esp-hal/src/rmt.rs index 72901ad74ed..6fefb0a3b43 100644 --- a/esp-hal/src/rmt.rs +++ b/esp-hal/src/rmt.rs @@ -684,6 +684,8 @@ mod impl_for_chip { } } + /// RMT Channel Creator + #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, @@ -767,6 +769,8 @@ mod impl_for_chip { } } + /// RMT Channel Creator + #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, @@ -858,6 +862,8 @@ mod impl_for_chip { } } + /// RMT Channel Creator + #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, From 3d79e47559b15434ec4240f88372980c76630574 Mon Sep 17 00:00:00 2001 From: liebman Date: Sun, 26 May 2024 08:27:43 -0700 Subject: [PATCH 4/5] esp-hal: update CHANGELOG --- esp-hal/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/esp-hal/CHANGELOG.md b/esp-hal/CHANGELOG.md index 1e3c342a285..af9d7c19321 100644 --- a/esp-hal/CHANGELOG.md +++ b/esp-hal/CHANGELOG.md @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - DMA transactions are now found in the `dma` module (#1550) - Remove unnecessary generics from PARL_IO driver (#1545) - Use `Level enum` in GPIO constructors instead of plain bools (#1574) +- rmt: make ChannelCreator public (#1597) ### Removed From 7b4ddb12ea866df15648e2b3ab5dc963300dab97 Mon Sep 17 00:00:00 2001 From: liebman Date: Mon, 27 May 2024 09:05:03 -0700 Subject: [PATCH 5/5] rmt: ChannelCreator: remove allow(missing_docs) --- esp-hal/src/rmt.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/esp-hal/src/rmt.rs b/esp-hal/src/rmt.rs index 6fefb0a3b43..7c5224cdff2 100644 --- a/esp-hal/src/rmt.rs +++ b/esp-hal/src/rmt.rs @@ -685,7 +685,6 @@ mod impl_for_chip { } /// RMT Channel Creator - #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, @@ -770,7 +769,6 @@ mod impl_for_chip { } /// RMT Channel Creator - #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, @@ -863,7 +861,6 @@ mod impl_for_chip { } /// RMT Channel Creator - #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode, @@ -956,7 +953,6 @@ mod impl_for_chip { } /// RMT Channel Creator - #[allow(missing_docs)] pub struct ChannelCreator where M: crate::Mode,