Mark some dependencies as unstable #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
unstable-deps
branch
from
9180fee to
16996e6
Compare
bugadani
force-pushed
the
unstable-deps
branch
from
7c76396 to
0956156
Compare
jessebraham
approved these changes
Dec 3, 2024
bjoernQ
reviewed
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the TWAI and USB serial drivers are unstable, marking the trait impls separately has some future compatibility benefit as we'll not have to do it when we stabilize the peripheral driver.
I guess we could try and upstream a
instability::unstable_trait_implmacro, and maybe anunstable_use.Please generate documentation and see if it looks right to you.
cc #2499