This repository has been archived by the owner on May 23, 2024. It is now read-only.
Don't double-lock in defmt #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
defmt
branch
2 times, most recently
from
ac78112 to
195a975
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bugadani
force-pushed
the
defmt
branch
2 times, most recently
from
7869d93 to
45b7ae9
Compare
bugadani
force-pushed
the
defmt
branch
2 times, most recently
from
116786f to
9396dc0
Compare
bjoernQ
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defmt implementation already creates a critical section if enabled. It needs to, because the framing must not be interspersed with other output. This PR removes an inner lock in the do_write calls, making the driver a bit lighter.
Since we're waiting for the FIFO to clear this may not have any significant runtime effect.