Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github API request returns only a few releases #460

Closed
SergioGasquez opened this issue Dec 9, 2024 · 2 comments · Fixed by #462
Closed

Github API request returns only a few releases #460

SergioGasquez opened this issue Dec 9, 2024 · 2 comments · Fixed by #462
Assignees
Labels
bug Something isn't working

Comments

@SergioGasquez
Copy link
Member

Bug description

While working on esp-rs/xtensa-toolchain#30, noticed that the xtensa-toolchain started failing (its trying to install 1.64.0.0), looking at the workflow and the reply of the github api request (https://api.github.com/repos/esp-rs/rust-build/releases) we see that the requested version is not there as gh only gives 9 latest releases.

Expected behavior

We can install any version, no matter how old it is.

@SergioGasquez SergioGasquez added the bug Something isn't working label Dec 9, 2024
@SergioGasquez SergioGasquez self-assigned this Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Dec 9, 2024
@jessebraham
Copy link
Member

per_page should be set to 30 by default, does explicitly specifying a value for this in the request (e.g. 100) resolve the issue?

@SergioGasquez
Copy link
Member Author

per_page should be set to 30 by default, does explicitly specifying a value for this in the request (e.g. 100) resolve the issue?

Yes, using:

-const XTENSA_RUST_API_URL: &str = "https://api.github.com/repos/esp-rs/rust-build/releases";
+const XTENSA_RUST_API_URL: &str =
+    "https://api.github.com/repos/esp-rs/rust-build/releases?page=1&per_page=1000";

seems to solve the issue

@SergioGasquez SergioGasquez linked a pull request Dec 10, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants