-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing broke by #8507 and arduino-builder update #8659
Comments
#8545 ? |
-edited- Lots of stuff happening in that PR other than the incorrect signature calc. I'll need some time to grok exactly what's going on in it. FWIW undoing the 1-liner change above seems to be enough to unbreak checks in the common case. -edit- I see one of the changes fixes this problem, great The platform.txt changes are also needed or the generated signing file will be ignored, it seems (with current Arduino cores....earlier revs worked but operated differently.) |
No rush, PR stayed there a long time anyway :> (also I don't really remember what I did there, but I do remember that I definitely tested it) |
I think it is already handled? Unless I misunderstood the issue with the builder / arduino-cli in IDE. Line 73 in 313b3c0
Line 134 in 313b3c0
BTW Is the issue with the orig java IDE or the new one? (or, if that matters at all) |
Yeah, that's the same thing we ended up on. So, no worries here then once #8545 gets in! Will close this, too. |
See discussion in earlephilhower/arduino-pico#783
arduino-builder
no longer includes{build.path}
in the includes, so the generatedUpdater_Signing.h
is never used.#8507 adjusts
_size
here but it should bebinSize
:Arduino/cores/esp8266/Updater.cpp
Lines 245 to 248 in 313b3c0
That means the signature will be calculated over the entire blob, including the signature itself, causing failure.
See the prior line:
Arduino/cores/esp8266/Updater.cpp
Line 238 in 520233f
The text was updated successfully, but these errors were encountered: