Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about retiring armv7 #4497

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Dec 10, 2024

Description:

SSIA

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@kbx81 kbx81 requested a review from jesserockz December 10, 2024 01:35
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit db1aae4
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/67579ad24a808d0008b693bc
😎 Deploy Preview https://deploy-preview-4497--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Walkthrough

The pull request introduces significant updates in the changelog for ESPHome version 2024.11.0, including a rebranding to ESPHome Device Compiler. Key features added are the ability to ignore discovered devices in the dashboard and several new components, such as the TC74 temperature sensor and the MAX17043 battery gauge. It also includes breaking changes like the renaming of the qspi_dbi platform, modifications to the http_request component, and updates to the lvgl light schema. The release emphasizes ongoing support and improvements, particularly for Docker.

Changes

File Path Change Summary
changelog/2024.11.0.rst - New feature: Support for ignoring discovered devices.
- New components: TC74 temperature sensor, MAX17043 battery gauge, I2S Speaker, OpenTherm component.
- Breaking changes: Renamed qspi_dbi, http_request response status change, lvgl light schema update, touchscreen calibration fixes, spi_device mode rename, update of UNIT_VOLT_AMPS_REACTIVE.

Possibly related PRs

Suggested reviewers

  • frenck
  • jesserockz

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
changelog/2024.11.0.rst (2)

46-46: Fix typo in the word "especially"

There's a typo in the word "especially" (spelled as "especiallly").

-especiallly if you're using the ESPHome Device Compiler to build/compile firmware for your
+especially if you're using the ESPHome Device Compiler to build/compile firmware for your

40-47: Consider making the Docker support retirement notice more prominent

The retirement of armv7 Docker support is a significant breaking change that affects users. Consider:

  1. Moving this section higher in the changelog
  2. Adding it to the "Breaking Changes" section
  3. Adding a warning box around the notice to make it more visible
+.. warning::
+
 ESPHome ``armv7`` Docker Support
 --------------------------------

 We will be retiring ESPHome's Docker support for ``armv7`` hardware in the February 2025 release.

 This is due to both waning support as it relates to tooling and performance reasons. We strongly recommend moving to a
 more modern architecture, especially if you're using the ESPHome Device Compiler to build/compile firmware for your
 devices.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd164a and db1aae4.

📒 Files selected for processing (1)
  • changelog/2024.11.0.rst (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
changelog/2024.11.0.rst (1)

Pattern **: - Do not generate or add any sequence diagrams

@jesserockz jesserockz merged commit 6d2a69f into esphome:current Dec 10, 2024
3 checks passed
@jesserockz jesserockz mentioned this pull request Dec 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants