-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about retiring armv7
#4497
Add note about retiring armv7
#4497
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe pull request introduces significant updates in the changelog for ESPHome version 2024.11.0, including a rebranding to ESPHome Device Compiler. Key features added are the ability to ignore discovered devices in the dashboard and several new components, such as the TC74 temperature sensor and the MAX17043 battery gauge. It also includes breaking changes like the renaming of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
changelog/2024.11.0.rst (2)
46-46
: Fix typo in the word "especially"There's a typo in the word "especially" (spelled as "especiallly").
-especiallly if you're using the ESPHome Device Compiler to build/compile firmware for your +especially if you're using the ESPHome Device Compiler to build/compile firmware for your
40-47
: Consider making the Docker support retirement notice more prominentThe retirement of
armv7
Docker support is a significant breaking change that affects users. Consider:
- Moving this section higher in the changelog
- Adding it to the "Breaking Changes" section
- Adding a warning box around the notice to make it more visible
+.. warning:: + ESPHome ``armv7`` Docker Support -------------------------------- We will be retiring ESPHome's Docker support for ``armv7`` hardware in the February 2025 release. This is due to both waning support as it relates to tooling and performance reasons. We strongly recommend moving to a more modern architecture, especially if you're using the ESPHome Device Compiler to build/compile firmware for your devices.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
changelog/2024.11.0.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
changelog/2024.11.0.rst (1)
Pattern **
: - Do not generate or add any sequence diagrams
Description:
SSIA
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.