Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support polarity for SDCard Write Protect testing (IDFGH-9892) #11208

Closed
a2retro opened this issue Apr 16, 2023 · 2 comments
Closed

Support polarity for SDCard Write Protect testing (IDFGH-9892) #11208

a2retro opened this issue Apr 16, 2023 · 2 comments
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@a2retro
Copy link

a2retro commented Apr 16, 2023

Is your feature request related to a problem?

/// Return true if WP pin is configured and is low
static bool card_write_protected(slot_info_t *slot)
{
if (slot->gpio_wp == GPIO_UNUSED) {
return false;
}
return gpio_get_level(slot->gpio_wp) == 0;
}

The code assumes low means a card is write protected.
Some SDCard are the opposite to that setting for example this card
https://www.digikey.ca/en/products/detail/3m/SD-RSMT-2-MQ-WF/1616663

Describe the solution you'd like.

Support polarity for SDCard Write Protect testing

Describe alternatives you've considered.

No response

Additional context.

No response

@a2retro a2retro added the Type: Feature Request Feature request for IDF label Apr 16, 2023
@github-actions github-actions bot changed the title Support polarity for SDCard Write Protect testing Support polarity for SDCard Write Protect testing (IDFGH-9892) Apr 16, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 16, 2023
@igrr
Copy link
Member

igrr commented Apr 18, 2023

@a2retro Could you please add, which ESP chip are you using? I can suggest an alternative solution which will not require adding a new feature to the SDSPI driver, but this solution is a bit chip-specific.

@a2retro
Copy link
Author

a2retro commented Apr 21, 2023

Hi I am using the esp32-S3 chip. Thank You.

@espressif-bot espressif-bot added the Awaiting Response awaiting a response from the author label Apr 24, 2023
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Apr 24, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Awaiting Response awaiting a response from the author Status: Selected for Development Issue is selected for development labels May 2, 2023
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: In Progress Work is in progress labels May 22, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed and removed Status: Selected for Development Issue is selected for development Status: In Progress Work is in progress labels Jun 12, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Reviewing Issue is being reviewed labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

4 participants