Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error when console UART set to None (IDFGH-2780) #4845

Closed
KaeLL opened this issue Feb 26, 2020 · 3 comments
Closed

Build error when console UART set to None (IDFGH-2780) #4845

KaeLL opened this issue Feb 26, 2020 · 3 comments
Assignees

Comments

@KaeLL
Copy link
Contributor

KaeLL commented Feb 26, 2020

IDF git describe: v4.2-dev-432-gc65b67115

esp-idf/components/console/esp_console_repl.c:125:22: error: 'CONFIG_ESP_CONSOLE_UART_BAUDRATE' undeclared

The existence of this constant is tied to the default setting, but it's still used in IDF.

@github-actions github-actions bot changed the title Build error when console UART set to None Build error when console UART set to None (IDFGH-2780) Feb 26, 2020
@AxelLin
Copy link
Contributor

AxelLin commented Mar 2, 2020

I got the same build error with v4.2-dev-521-g6fd855ab8d00.

@AxelLin
Copy link
Contributor

AxelLin commented Mar 5, 2020

Hi @Alvin1Zhang @suda-morris

Any chance to fix the build error ASAP? IMHO, a build breakage should be high priority to fix.

BTW, I think esp_console_repl_init() should also takes "const uart_config_t *uart_config" argument
so the caller can use different uart settings.

@suda-morris
Copy link
Collaborator

@KaeLL Sorry for the delay, we will fix it ASAP. Thanks for your nice suggestion. @AxelLin

@suda-morris suda-morris self-assigned this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants