esp_http_client_close always returns -1 on an https request (IDFGH-2810)

[sebirdman]

Problem Description

in the current 3.3 stable branch and master branches esp_http_client_close always returns ESP_FAIL. The errno is always 9.

This appears to be a result of transport_ssl.c's implementation of ssl_close where the return value is always -1

esp-idf/components/tcp_transport/transport_ssl.c

Line 168 in aa3b1da

static int ssl_close(esp_transport_handle_t t)

static int ssl_close(esp_transport_handle_t t)
{
    int ret = -1;
    transport_ssl_t *ssl = esp_transport_get_context_data(t);
    if (ssl->ssl_initialized) {
        esp_tls_conn_delete(ssl->tls);
        ssl->ssl_initialized = false;
    }
    return ret;
}

because the current implementation of esp_http_client_close always returns the result of esp_transport_close.

This conflicts with the names of the returned values according to the docs: https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/protocols/esp_http_client.html#_CPPv421esp_http_client_close24esp_http_client_handle_t

[AxelLin]

The same issue on git master tree:
https://github.com/espressif/esp-idf/blob/master/components/tcp_transport/transport_ssl.c#L168
https://github.com/espressif/esp-idf/blob/master/components/tcp_transport/transport_tcp.c#L162

[david-cermak]

Thanks @sebirdman for posting this issue. Seems like an oversight which needs fixing.