Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power metering (MEGH-3343) #121

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

brainstorm
Copy link

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Power metering Power metering (MEGH-3343) Mar 26, 2022
@shahpiyushv
Copy link
Collaborator

@brainstorm , we have some reservations for this PR because ESP standard devices/params are typically meant for special handling either in our official phone apps or our 3rd party integrations like Alexa/GVA. Since there is no "power meter" category in Alexa/GVA and no immediate plan to add this in the phone apps either, we will need some more time to decide whether to merge this or not. I will also check internally to see if anyone had created any demo for Energy meters, and if some names were already chosen.

Meanwhile, since custom examples need not use standard types, I am hoping that this isn't blocking any of your projects.

@brainstorm
Copy link
Author

brainstorm commented Apr 5, 2022

Thanks @shahpiyushv, it doesn't block any of my projects, I was just going by the same moves as #105, didn't know about Alexa/GVA side of things since I don't own one nor I'm interested in them.

I guess that I could do the same thing just sticking with other custom type(s)? Then there's no need to go with has been done in this PR ;)

Feel free to close this PR it in any case if it doesn't serve yours or Espressif's needs. Cheers!

@brainstorm
Copy link
Author

brainstorm commented Oct 25, 2022

I wanted to contribute power metering cluster/attributes writing on the Matter spec after reading the relevant Matter 1.0 spec PDFs:

https://csa-iot.org/wp-content/uploads/2022/10/22-27349-001_Matter-1.0-Core-Specification76.pdf
https://csa-iot.org/wp-content/uploads/2022/10/22-27351-001_Matter-1.0-Device-Library-Specification39.pdf
https://csa-iot.org/wp-content/uploads/2022/10/22-27350-001_Matter-1.0-Application-Cluster-Specification15.pdf

But apparently it's a private repository so the public cannot make pull requests?: project-chip/connectedhomeip#23339 (comment)

I guess that for now I'll have to go with the custom data model documented on esp-matter docs to match the power metering needs (fairly close to i.e the temperature sensor present in the 1.0 Matter spec anyway). Not ideal since I guess it'll complicate the Matter certification process later on, so please let me know if there's some avenue where I can contribute to the official spec without the pricey membership model/tiers from csa-iot.

@dhrishi
Copy link
Contributor

dhrishi commented Oct 26, 2022

@brainstorm I think it is not possible right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants