From 74ebf8d7b348a503e2ae3ff6096a71a49f56d6b5 Mon Sep 17 00:00:00 2001
From: Jakub Kocka <jakub.kocka@espressif.com>
Date: Tue, 26 Mar 2024 06:43:47 +0100
Subject: [PATCH] fix: Fixed running called worflow only for chosen installer
 type

---
 .github/workflows/build-installer.yml | 6 +++---
 scripts/docs_update_release.py        | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build-installer.yml b/.github/workflows/build-installer.yml
index 4d55a06..a795b0a 100644
--- a/.github/workflows/build-installer.yml
+++ b/.github/workflows/build-installer.yml
@@ -35,7 +35,7 @@ env:
 jobs:
     build-installer-online:
         name: Build Online Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'online'
+        if: inputs.installer_type == 'online'
         uses: espressif/idf-installer/.github/workflows/build-online-installer.yml@main
         with:
             online_installer_version: ${{ inputs.online_installer_version }}
@@ -43,7 +43,7 @@ jobs:
 
     build-installer-offline:
         name: Build Offline Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'offline'
+        if: inputs.installer_type == 'offline'
         uses: espressif/idf-installer/.github/workflows/build-offline-installer.yml@main
         with:
             esp_idf_version: ${{ inputs.esp_idf_version}}
@@ -51,7 +51,7 @@ jobs:
 
     build-installer-ide:
         name: Build IDE Installer
-        if: ${{ github.env.INSTALLER_TYPE }} == 'espressif-ide'
+        if: inputs.installer_type == 'espressif-ide'
         uses: espressif/idf-installer/.github/workflows/build-espressif-ide-installer.yml@main
         with:
             esp_idf_version: ${{ inputs.esp_idf_version }}
diff --git a/scripts/docs_update_release.py b/scripts/docs_update_release.py
index 95af451..1bb9a58 100644
--- a/scripts/docs_update_release.py
+++ b/scripts/docs_update_release.py
@@ -160,7 +160,7 @@ def main():
     supported_idf_versions = eval(environ.get('SUPPORTED_IDF_VERSIONS', "('5.2', '4.4', '5.1', '5.0')"))    # e.g. ('5.2', '4.4', '5.1', '5.0')
     supported_idf_versions = list(supported_idf_versions)
 
-    if not idf_version:
+    if not idf_version and installer_type != 'online':
         raise SystemExit("ERROR: IDF version is not provided")
     
     # cast IDF version to list