From f5ecca2b3cf80557fda34c546f2588f76f0fb1a6 Mon Sep 17 00:00:00 2001
From: "Brian A. Ignacio" <brian.ignacio@espressif.com>
Date: Wed, 23 Oct 2024 09:48:00 +0800
Subject: [PATCH] fix pr comment rm build flash telemetry (#1328)

---
 .github/workflows/pr-comment.yml | 2 +-
 src/build/buildCmd.ts            | 4 +++-
 src/flash/uartFlash.ts           | 8 +++++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml
index e775fbdd9..da9fb7764 100644
--- a/.github/workflows/pr-comment.yml
+++ b/.github/workflows/pr-comment.yml
@@ -49,7 +49,7 @@ jobs:
               return core.error(`No artifacts found`);
             }
             let body = `Download the artifacts for this pull request:\n`;
-            body += `You can test these changes by installing this VSIX by click menu `View` -> `Command Palette...`, type `Install from VSIX` and then select downloaded `esp-idf-extension.vsix` file to install the extension.`;
+            body += `You can test these changes by installing this VSIX by click menu **View** -> **Command Palette...**, type **Install from VSIX** and then select downloaded **esp-idf-extension.vsix** file to install the extension.`;
             for (const art of artifacts) {
               body += `\n* [${art.name}.zip](https://nightly.link/${owner}/${repo}/actions/artifacts/${art.id}.zip)`;
             }
diff --git a/src/build/buildCmd.ts b/src/build/buildCmd.ts
index c474e5b7d..ed62671d0 100644
--- a/src/build/buildCmd.ts
+++ b/src/build/buildCmd.ts
@@ -103,7 +103,9 @@ export async function buildCommand(
     Logger.errorNotify(
       "Something went wrong while trying to build the project",
       error,
-      "buildCommand"
+      "buildCommand",
+      undefined,
+      false
     );
     continueFlag = false;
   }
diff --git a/src/flash/uartFlash.ts b/src/flash/uartFlash.ts
index ef94dbf2f..89f1aca86 100644
--- a/src/flash/uartFlash.ts
+++ b/src/flash/uartFlash.ts
@@ -129,7 +129,13 @@ export async function flashCommand(
     }
     const errStr = `Failed to flash because of some unusual error. Check Terminal for more details`;
     OutputChannel.appendLine(errStr, "Flash");
-    Logger.errorNotify(errStr, error, "flashCommand unknown error");
+    Logger.errorNotify(
+      errStr,
+      error,
+      "flashCommand unknown error",
+      undefined,
+      false
+    );
     continueFlag = false;
   }
   FlashTask.isFlashing = false;