Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Running the size task after the build task succeeds should not be so interruptive (VSC-1100) #954

Closed
henryshunt opened this issue Apr 26, 2023 · 4 comments · Fixed by #965
Assignees
Labels
Feature / Enhancement Request Request for Feature/ Enhancement
Milestone

Comments

@henryshunt
Copy link

henryshunt commented Apr 26, 2023

After the build task completes without errors, the size task runs. This is very annoying because it opens a new terminal tab when I'm trying to read the output of the build task. If I catch that the build task has something I wish to look at (e.g. warnings), the size task quickly switches in and I have to click to get back to the build task. Also, I often start the build task and then close the terminal, but the size task inevitably causes it to open back up again unannounced. Finally, I personally don't really have any need to see the size info, certainly not after every single build.

The contents of the size task should run as part of the build task (so it doesn't open a separate tab), or there should be an option to disable the size task from automatically running after the build task (something I looked for but did not find).

@henryshunt henryshunt added the Feature / Enhancement Request Request for Feature/ Enhancement label Apr 26, 2023
@github-actions github-actions bot changed the title [Feature Request]: Running the size task after the build task succeeds should not be so interruptive [Feature Request]: Running the size task after the build task succeeds should not be so interruptive (VSC-1100) Apr 26, 2023
@brianignacio5
Copy link
Collaborator

Hi @henryshunt thank you for your feedback. Will add an extension setting to disable this size task after build and share the vsix installer for you to try and see if it's okay.

I'll add a link in a bit from the PR

@henryshunt
Copy link
Author

Much appreciated, thank you!

@brianignacio5 brianignacio5 added this to the v1.6.3 milestone May 5, 2023
@brianignacio5 brianignacio5 self-assigned this May 5, 2023
@brianignacio5
Copy link
Collaborator

Could you try this vsix installer to see if the issue is fixed ?

@vsh-ektos
Copy link

@brianignacio5 It seems to work well, but the build task (not the build itself) does not complete
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement Request Request for Feature/ Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants