-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Local particles #2400
WIP: Local particles #2400
Conversation
…r<Particle *>, removed some unused things form particle_data.
… empty, and adapted index check. Cleaner way out if particle sorting fails.
…ded updates of local_particles.
…local_particles
Codecov Report
@@ Coverage Diff @@
## python #2400 +/- ##
=======================================
- Coverage 77% 75% -2%
=======================================
Files 498 494 -4
Lines 27891 27956 +65
=======================================
- Hits 21492 21174 -318
- Misses 6399 6782 +383
Continue to review full report at Codecov.
|
|
Performance decreases by some 5% for a 1000 particle lj fluid at 0.1 volume fraction. |
…local_particles
…local_particles
…local_particles
…local_particles
Your pull request does not meet our code formatting rules. To fix this, please do one of the following:
You can run Please note that there are often multiple ways to correctly format code. As I am just a robot, I sometimes fail to identify the most aesthetically pleasing way. So please look over my suggested changes and adapt them where the style does not make sense. |
Description of changes:
index by a hash map.
by the regular particle sorting code instead of duplicated code.
This finally makes Espresso linear in memory consumption.
If the performance with the
std::unordered_map
is too badwe could replace it by a better one e.g. from abseil, but for
the reduced complexity in bookkeeping I really would like to
get this in.