Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous cargo-features = ["edition2024"] requirement in projects using nightly when this not needed any more #292

Closed
virtualritz opened this issue Dec 18, 2024 · 2 comments

Comments

@virtualritz
Copy link

virtualritz commented Dec 18, 2024

See subject -- edition = "2024" was stabilized on nightly on Nov. 28th. If one uses a nightly after that (I do) cargo notices the user that the resp. line cargo-features = ["edition2024"] can be removed from Cargo.toml (I did).

However, cargo udeps (and cargo +nightly udeps) refuse to run even when the resp. project is using nightly and the locally installed nighly toolchain is current (i.e. after Nov. 28th).

As this affects all local dependencies this is not just adding a single line to make the error go away but requires (re-)adding this to all local depdencies' Cargo.toml's that have edition = "2024" set (about two dozen, in my case).

Example:

error: failed to get `openimageio-sys` as a dependency of package `openimageio v0.1.0 (/home/ritz/code/crates/openimageio)`
    ... which satisfies path dependency `openimageio` (locked to 0.1.0) of package `nci-cli v0.1.0 (/home/ritz/code/crates/nci/crates/nci-cli)`

Caused by:
  failed to load source for dependency `openimageio-sys`

Caused by:
  Unable to update /home/ritz/code/crates/openimageio/openimageio-sys

Caused by:
  failed to parse manifest at `/home/ritz/code/crates/openimageio/openimageio-sys/Cargo.toml`

Caused by:
  feature `edition2024` is required

  The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.80.0).
  Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.
@est31
Copy link
Owner

est31 commented Dec 18, 2024

Hi, thanks for beta testing the 2024 edition.

As described in my comment here, you can use a local build of cargo-udeps until the 2024 edition hits stable: #290 (comment)

@est31 est31 closed this as completed Dec 18, 2024
@virtualritz
Copy link
Author

Cheers! See my comment on the other issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants