Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing style of studentProfile #89

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

joaoprferreira
Copy link
Member

@joaoprferreira joaoprferreira commented Mar 10, 2022

#74

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for dev-estartandodevs ready!

🔨 Explore the source changes: a29a041

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/622a8b950c30b900090dbc2b

😎 Browse the preview: https://deploy-preview-89--dev-estartandodevs.netlify.app/

jonataspinto
jonataspinto previously approved these changes Mar 10, 2022
@jonataspinto
Copy link
Member

Build quebrando @joaoprferreira

Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
@jonataspinto
Copy link
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.57
First Contentful Paint 1.3 s
Time to Interactive 4.9 s
Speed Index 1.7 s
Total Blocking Time 760 ms
Largest Contentful Paint 6.7 s
Cumulative Layout Shift 0.001
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.93
First Contentful Paint 2.0 s
Time to Interactive 5.8 s
Speed Index 2.4 s
Total Blocking Time 110 ms
Largest Contentful Paint 2.1 s
Cumulative Layout Shift 0.001

Copy link
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@joaoprferreira
Copy link
Member Author

Build quebrando @joaoprferreira

Fixed

@jonataspinto
Copy link
Member

Build quebrando @joaoprferreira

Fixed

Merrrge

@joaoprferreira joaoprferreira merged commit a89606e into develop Mar 10, 2022
@joaoprferreira joaoprferreira deleted the fix/feature-student-profile branch March 10, 2022 23:43
@jonataspinto
Copy link
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.73
First Contentful Paint 1.3 s
Time to Interactive 4.4 s
Speed Index 1.5 s
Total Blocking Time 280 ms
Largest Contentful Paint 6.3 s
Cumulative Layout Shift 0.001
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.67
First Contentful Paint 2.0 s
Time to Interactive 5.7 s
Speed Index 2.4 s
Total Blocking Time 160 ms
Largest Contentful Paint 11.8 s
Cumulative Layout Shift 0.172

Copy link
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@jonataspinto jonataspinto mentioned this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correção de layout em section de perfil do aluno
2 participants