Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/75 usar elementos de lista em listagem de módulos #90

Merged

Conversation

joaoprferreira
Copy link
Member

@joaoprferreira joaoprferreira commented Mar 11, 2022

Ticket | Mocks

Description

como surgiu a demanda para alterar esse componente para uma lista fiz com uma lista normal.

  1. List all steps in a numbered list

Screenshots / Videos

image

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

@joaoprferreira joaoprferreira linked an issue Mar 11, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Mar 11, 2022

✔️ Deploy Preview for dev-estartandodevs ready!

🔨 Explore the source changes: 9228d7c

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/622a98dcf5a1b4000842573b

😎 Browse the preview: https://deploy-preview-90--dev-estartandodevs.netlify.app/

@jonataspinto
Copy link
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.64
First Contentful Paint 1.2 s
Time to Interactive 4.8 s
Speed Index 1.5 s
Total Blocking Time 520 ms
Largest Contentful Paint 6.3 s
Cumulative Layout Shift 0.001
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.93
First Contentful Paint 2.0 s
Time to Interactive 5.7 s
Speed Index 2.4 s
Total Blocking Time 140 ms
Largest Contentful Paint 2.1 s
Cumulative Layout Shift 0.001

Copy link
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Copy link
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltou o implementar o details, mas uma alteração não impede a outra.

LGTM

@jonataspinto jonataspinto merged commit 41659b7 into develop Mar 11, 2022
@jonataspinto jonataspinto deleted the fix/75-usar-elementos-de-lista-em-listagem-de-módulos branch March 11, 2022 00:50
@jonataspinto jonataspinto mentioned this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usar elementos de lista em listagem de módulos.
2 participants