:has(selector) matches nodes matched by selector

[mdjermanovic]

esquery v1.4.0

const literal = espree.parse("1").body[0].expression;
const selector = esquery.parse(":has(Literal)");

esquery.matches(literal, selector); // true

Or. in the esquery demo, enter 1 as code, :has(Literal) as selector. It finds "Program", "ExpressionStatement", and "Literal".

I was expecting that selectors in :has() can match only descendants of the node, but in the above examples :has(Literal) matches a Literal node. Is this the intended behavior?

[lukaw3d]

Can still reproduce this, e.g. if (y) { y += 'z'; } matches BlockStatement:has(BlockStatement:has(BlockStatement))

The cause is

esquery/esquery.js

Lines 179 to 191 in 07ee329

	estraverse.traverse(node, {
	enter (node, parent) {
	if (parent != null) { a.unshift(parent); }
	for (let i = 0; i < matchers.length; ++i) {
	if (matchers[i](node, a, options)) {
	result = true;
	this.break();
	return;
	}
	}
	},
	leave () { a.shift(); },

enter and leave visit node too. A simple fix is master...lukaw3d:esquery:remove-parent-from-has

                estraverse.traverse(node, {
                    enter (descendant, parent) {
                        if (node === descendant) return;
                        ...

                    leave (descendant) {
                        if (node === descendant) return;
                        ...