Skip to content

Commit

Permalink
Merge pull request #11200 from jingyih/automated-cherry-pick-of-#1119…
Browse files Browse the repository at this point in the history
…4-origin-release-3.4

Automated cherry pick of #11194 on release-3.4
  • Loading branch information
gyuho authored Oct 3, 2019
2 parents c91a6bf + b7ff97f commit dae0a72
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions etcdctl/ctlv3/command/member_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,20 +158,22 @@ func memberAddCommandFunc(cmd *cobra.Command, args []string) {
if _, ok := (display).(*simplePrinter); ok {
ctx, cancel = commandCtx(cmd)
listResp, err := cli.MemberList(ctx)
// get latest member list; if there's failover new member might have outdated list
// make sure the member who served member list request has the latest member list.
syncedMemberSet := make(map[uint64]struct{})
syncedMemberSet[resp.Header.MemberId] = struct{}{} // the member who served member add is guaranteed to have the latest member list.
for {
if err != nil {
ExitWithError(ExitError, err)
}
if listResp.Header.MemberId == resp.Header.MemberId {
if _, ok := syncedMemberSet[listResp.Header.MemberId]; ok {
break
}
// quorum get to sync cluster list
gresp, gerr := cli.Get(ctx, "_")
if gerr != nil {
ExitWithError(ExitError, err)
}
resp.Header.MemberId = gresp.Header.MemberId
syncedMemberSet[gresp.Header.MemberId] = struct{}{}
listResp, err = cli.MemberList(ctx)
}
cancel()
Expand Down

0 comments on commit dae0a72

Please sign in to comment.