Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some questions about the implementation of intervalTree #11337

Closed
liyue201 opened this issue Nov 7, 2019 · 1 comment
Closed

some questions about the implementation of intervalTree #11337

liyue201 opened this issue Nov 7, 2019 · 1 comment

Comments

@liyue201
Copy link

liyue201 commented Nov 7, 2019

sentinel *intervalNode

i don't think the implementation of intervalTree is good. why don't use go nil as NIL leaf node. i have saw this issue #10881 (comment)

i not think the reason is go nil, but this function

func (ivt *intervalTree) deleteFixup(x *intervalNode) {
it does not supports nil parameter.

@spzala
Copy link
Member

spzala commented Nov 7, 2019

@liyue201 for code related changes/proposals, I would suggest to create PR for a better discussion and review. Hope makes sense. I am closing this issue but please feel free to create a PR or reopen this if you want. Thanks!

@spzala spzala closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants