Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] The semaphoreci fails from time to time #13702

Closed
ahrtr opened this issue Feb 16, 2022 · 7 comments
Closed

[test] The semaphoreci fails from time to time #13702

ahrtr opened this issue Feb 16, 2022 · 7 comments

Comments

@ahrtr
Copy link
Member

ahrtr commented Feb 16, 2022

The error message is

Step 1/14 : FROM ubuntu:21.10
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
make[1]: *** [build-docker-test] Error 1
make[1]: Leaving directory `/home/runner/etcd'
make: *** [ensure-docker-test-image-exists] Error 2

The base image in Dockerfile is ubuntu:21.10 , each time when running the build-docker-test , it pulls the base image. Sometimes it may fail due to the docker hub's rate limitation.

I think we may need to put the base image to another image registry. cc @serathius @ptabor @spzala

@chaochn47
Copy link
Member

@ahrtr, vote for aws ECR public gallery for pulling docker images from my knowledge. The quota is 1 image pull per second for unauthenticated user which is better than the following docker policy.

Anonymous and Free Docker Hub users are limited to 100 and 200 container image pull requests per six hours
https://www.docker.com/increase-rate-limits

Docker already automatically pushed their public images to ECR public https://www.docker.com/blog/news-from-aws-reinvent-docker-official-images-on-amazon-ecr-public/.

So ubuntu:21.10 will be changed to public.ecr.aws/docker/library/ubuntu:21.10.

Pushing and pulling the ubuntu images from the gcr etcd account may be another option.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 16, 2022

Looks good to me, at lease we can resolve the semaphoreci failure for now. The public.ecr.aws/docker/library/ubuntu:21.10 is already available,

$ docker pull public.ecr.aws/docker/library/ubuntu:21.10
21.10: Pulling from docker/library/ubuntu
24496884391b: Pull complete 
Digest: sha256:1108598c6469492b0ec61c4c9bab6868a3d335ecf76deb4d31ff3b2615170ae9
Status: Downloaded newer image for public.ecr.aws/docker/library/ubuntu:21.10
public.ecr.aws/docker/library/ubuntu:21.10

@serathius
Copy link
Member

I don't think we should pick up another dependency, especially when we are almost ready to disable those tests #13448.

Only think blocking us from removal is fact that branch release-3.3 depends on those tests and apparently there is no way to configure semaphore to just run on selected branches. I don't have access so I could not confirm that.

I previously tried to do migration to github actions (#13613), but didn't had time to fix all the errors. In the end decided to wait for v3.6 release as it would move the support window allowing us to ignore release-3.3 problems.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 16, 2022

Thanks @serathius for the info. I missed the info in 13448.

It's OK just to ignore the SemaphoreCI errors for now.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 16, 2022

Or can we just replace it withpublic.ecr.aws/docker/library/ubuntu:21.10for now, so as to make the CI green? We can remove the SemaphoreCI when 3.6 is out. WDYT @serathius ?

@serathius
Copy link
Member

cc @ptabor

@ahrtr
Copy link
Member Author

ahrtr commented Feb 17, 2022

There is already a related ticket 13448, so let's close this one.

@ahrtr ahrtr closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants