Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETCDCTL_PEERS is a confusing env name #3341

Closed
bkleef opened this issue Aug 20, 2015 · 3 comments
Closed

ETCDCTL_PEERS is a confusing env name #3341

bkleef opened this issue Aug 20, 2015 · 3 comments
Assignees
@xiang90
Milestone
v2.2.0

Comments

@bkleef
Copy link

bkleef commented Aug 20, 2015

Because default etcd peer port (server-to-server communication) is 2380 and this value should get an etcd (client communication) record with as default port 2379.

Let's rename it into ETCDCTL_ENDPOINT like FLEETCTL_ENDPOINT.
@xiang90
Copy link
Contributor

xiang90 commented Aug 25, 2015

@robszumski Any suggestion?

@xiang90 xiang90 added the ux label Aug 25, 2015
@robszumski
Copy link
Contributor

Sounds ok to me, but we'll need to leave in support for the old one.

@xiang90 xiang90 added this to the v2.2.0 milestone Aug 27, 2015
@xiang90 xiang90 self-assigned this Aug 27, 2015
@xiang90 xiang90 mentioned this issue Aug 27, 2015
Merged
@xiang90
Copy link
Contributor

xiang90 commented Aug 28, 2015

Closed via #3390

@xiang90 xiang90 closed this as completed Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiang90 xiang90

Labels
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@robszumski @bkleef @xiang90