Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client versioning #6579

Closed
heyitsanthony opened this issue Oct 4, 2016 · 2 comments
Closed

client versioning #6579

heyitsanthony opened this issue Oct 4, 2016 · 2 comments
Labels
area/performance
Milestone
v3.2.0

Comments

@heyitsanthony
Copy link
Contributor

If a new client is used with an old cluster, it may try to use options or flags the old server does not understand. Instead, there could be a Config option (or make it mandatory) to compare the client version against the cluster version; if the cluster is behind the client, the client will refuse to start.

Related: #6422
@xiang90 xiang90 mentioned this issue Oct 24, 2016
Closed
@heyitsanthony
Copy link
Contributor Author

Really the server should reject unknown fields exactly for this reason (instead of having to roll out own crummy versioning system), but it seems that feature was removed from proto3 because Google Knows Best.

@heyitsanthony heyitsanthony added this to the v3.2.0 milestone Dec 7, 2016
@sinsharat
Copy link
Contributor

@heyitsanthony @xiang90 if you give an insight on how exactly you want it to be implemented, then will start with it.

@heyitsanthony heyitsanthony mentioned this issue Feb 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@heyitsanthony @sinsharat