Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: grpc health checking service #8022

Closed
heyitsanthony opened this issue Jun 2, 2017 · 3 comments
Closed

api: grpc health checking service #8022

heyitsanthony opened this issue Jun 2, 2017 · 3 comments
Assignees

Comments

@heyitsanthony
Copy link
Contributor

See: https://github.com/grpc/grpc/blob/master/doc/health-checking.md

There are cases where the client needs to know that the server is responding to requests. If the server is not responding (but possibly still accepting connections), the balancer should try another endpoint. For instance, a watch may be disconnected but the connection will stay open and hang instead of connecting to another member.

via https://groups.google.com/d/msg/etcd-dev/N6DLgT9rl-M/LTp6j2XNAAAJ
additional grpc context https://groups.google.com/forum/#!topic/grpc-io/69k_6HKVai0

@heyitsanthony
Copy link
Contributor Author

Related: #7321

This heartbeat mechanism is somewhat weaker in that it doesn't need a leader, but there still needs to be some kind of polling to avoid waiting indefinitely on a disconnected socket. The client implementations for heartbeat/lost leader reconnect can both poll or lost leader can depend on heartbeat to cover the wait case.

@xiang90
Copy link
Contributor

xiang90 commented Oct 4, 2017

move this to 3.4

@gyuho
Copy link
Contributor

gyuho commented May 2, 2018

Moving to #8673, since it also needs client-side work.

@gyuho gyuho closed this as completed May 2, 2018
@gyuho gyuho removed this from the etcd-v3.4 milestone May 2, 2018
@gyuho gyuho removed the type/feature label May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants