Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lease: monotonic time has been supportted in go1.9 #8493

Closed
lorneli opened this issue Sep 5, 2017 · 3 comments
Closed

lease: monotonic time has been supportted in go1.9 #8493

lorneli opened this issue Sep 5, 2017 · 3 comments

Comments

@lorneli
Copy link
Contributor

lorneli commented Sep 5, 2017

Lease package needs monotonic time to measure whether a lease is expired. Previously, pkg/monotime implements monotonic time, using go:linkname to touch golang's runtime.nanotime.

Monotonic clock has been supportted in go1.9 (release note). As described in time package's doc, monotonic clock is used for time-measuring operations.

Is there any plan to replace pkg/monotime with go1.9 time package? By the way, Removing pkg/monotime has obvious shortcoming, requiring go version >= 1.9 to support this feature.
@heyitsanthony
Copy link
Contributor

duplicates #6174

@lorneli lorneli closed this as completed Sep 5, 2017
@gyuho
Copy link
Contributor

gyuho commented Sep 5, 2017

We still run CIs on 1.8.3. Once Semaphore supports Go 1.9, we will switch. Thanks.

@lorneli
Copy link
Contributor Author

lorneli commented Sep 6, 2017 •
edited
Loading

@gyuho My pleasure. Haven't seen your comment and created a pr #8507 few minutes ago. 🙈 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gyuho @heyitsanthony @lorneli