New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'context' in generated code #8520

Closed

1 of 4 tasks

gyuho opened this issue Sep 7, 2017 · 1 comment

Assignees

Milestone

Contributor

gyuho commented Sep 7, 2017

Replace golang.org/x/net/context with context in generated code:

google.golang.org/grpc (Replace "golang.org/x/net/context" with "context" and stop supporting go1.6 grpc/grpc-go#1160)
github.com/golang/protobuf (TODO Question: move to Go 1.7+ stdlib 'context' package? golang/protobuf#336)
github.com/gogo/protobuf (TODO Any plan to switch Go standard package 'context' gogo/protobuf#282)
github.com/grpc-ecosystem/grpc-gateway (TODO Move to stdlib context grpc-ecosystem/grpc-gateway#343)

Not a blocker for Go 1.9 migration, or 3.3 release.

c.f. #6174

The text was updated successfully, but these errors were encountered:

gyuho added the area/dependency label

heyitsanthony added this to the v3.4.0 milestone

heyitsanthony assigned gyuho

gyuho removed the area/dependency label

Contributor Author

gyuho commented May 2, 2018

With Go type alias and 1.10, this is resolved.

gyuho closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment