Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown field NoFreelistSync #8692

Closed
olivere opened this issue Oct 13, 2017 · 6 comments
Closed

Unknown field NoFreelistSync #8692

olivere opened this issue Oct 13, 2017 · 6 comments

Comments

@olivere
Copy link

olivere commented Oct 13, 2017

We are using the current master branch of etcd vendored with dep and keep getting an error when running our test suite with Linux.

go test -v -tags integration $(go list ./... | grep -v 'vendor\|kubernetes')
# github.com/xxx/yyy/vendor/github.com/coreos/etcd/mvcc/backend
vendor/github.com/coreos/etcd/mvcc/backend/config_linux.go:31:16: unknown field 'NoFreelistSync' in struct literal of type bolt.Options

We tried to switch back to 3.2.9, but unfortunately that yields in a different error due to breaking changes in grpc-go 1.6.0:

# github.com/xxx/yyy/vendor/github.com/coreos/etcd/clientv3
vendor/github.com/coreos/etcd/clientv3/client.go:336:9: undefined: metadata.NewContext
vendor/github.com/coreos/etcd/clientv3/lease.go:326:14: undefined: metadata.FromContext
# github.com/xxx/yyy/vendor/github.com/coreos/etcd/auth
vendor/github.com/coreos/etcd/auth/store.go:995:12: undefined: metadata.FromContext

Now we're stuck and only have the chance to choose between the two errors :-)

We have tried to get dep vendor the correct version of github.com/coreos/bbolt (which has the NoFreelistSync), but we're unsuccessful yet.

Is there anything we can do here?

@gyuho
Copy link
Contributor

gyuho commented Oct 13, 2017

We are using the current master branch of etcd

Did you vendor exactly the way we do here https://github.com/coreos/etcd/blob/master/glide.yaml#L7?

I've also tried dep for etcd, but don't think it's production-ready yet.

@olivere
Copy link
Author

olivere commented Oct 13, 2017

Aha! I will try that. Thank you! Will re-open if that won't work.

Re dep: They state here that they're production ready, and we're using it for ~2 months and didn't see any real issues besides being a bit slow when updating dependencies. But that's a known issue being worked on.

@olivere olivere closed this as completed Oct 13, 2017
@xiang90
Copy link
Contributor

xiang90 commented Oct 13, 2017

@olivere it would be great if you can explore if dep works for etcd, and maybe send a pr to demonstrate that. thank you.

@gyuho
Copy link
Contributor

gyuho commented Oct 13, 2017

@olivere Ok that's great to know 👍

If you're interested, #7225.

@olivere
Copy link
Author

olivere commented Oct 13, 2017

Hmm... that didn't do the trick with dep at least. But TBH I'm not sure if that's a problem with dep as it's trying to get github.com/boltdb/bolt instead of your fork at github.com/coreos/bbolot when I initialize with dep init, which finds and uses your Glide configuration (see my comment on #7225).

@olivere
Copy link
Author

olivere commented Oct 13, 2017

Ah, I was wrong. I didn't update from upstream. Will update my findings in #7225.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants