Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: document grpc-go error handling #8709

Closed
gyuho opened this issue Oct 18, 2017 · 1 comment
Closed

clientv3: document grpc-go error handling #8709

gyuho opened this issue Oct 18, 2017 · 1 comment

Comments

@gyuho
Copy link
Contributor

gyuho commented Oct 18, 2017

https://github.com/coreos/etcd/tree/master/clientv3#error-handling explains current error handling.
But we've upgraded gRPC to >v1.6. And lots of changes have happened in balancer/retrial logic.

With more fixes/changes to clientv3 on the way, now it's possible that clientv3 can receive errors from gRPC that are not grpc/status.(*statusError) type (e.g. grpc.ErrClientConnClosing in TestKVNewAfterClose, transport.ErrConnClosing in TestLeasingOwnerDeleteError).

c.f.

Either we convert the errors, or document clearly together with client upgrade guides.

@gyuho
Copy link
Contributor Author

gyuho commented Nov 27, 2017

Partially covered by #8896.
Need update clientv3/doc.go on the gRPC connection errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants