Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/maintenance: add alarm/health information in endpoint status #9163

Closed
gyuho opened this issue Jan 18, 2018 · 8 comments
Closed

api/maintenance: add alarm/health information in endpoint status #9163

gyuho opened this issue Jan 18, 2018 · 8 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 18, 2018

#9162 removes "errors" field from /health endpoint.

Better place to serve this information is etcdserverpb.StatusResponse. Probably, just add another repeated field of errors.
@gyuho
Copy link
Contributor Author

gyuho commented Jan 19, 2018

@dvonthenen Do you want to work on this (very similar to #9176)?

@dvonthenen
Copy link

dvonthenen commented Jan 19, 2018 •
edited
Loading

@gyuho Sure thing! If you have any other ones, just let me know.

@dvonthenen
Copy link

@gyuho Do we want to also expose these errors on the etcdctl table output?

@gyuho
Copy link
Contributor Author

gyuho commented Jan 23, 2018

@dvonthenen Yes. Thanks!

@dvonthenen
Copy link

No problem

@dvonthenen dvonthenen mentioned this issue Jan 23, 2018
Merged
@dvonthenen
Copy link

PR #9206 submitted

@dvonthenen dvonthenen mentioned this issue Jan 23, 2018
Open
9 tasks
@dvonthenen
Copy link

I believe this issue can be closed since PR #9206 has been merged. Thanks!

@xiang90
Copy link
Contributor

xiang90 commented Jan 30, 2018

@dvonthenen thanks for the contribution.

@xiang90 xiang90 closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiang90 @gyuho @dvonthenen