From e402606f024451703995729cdb663395c99c8ad8 Mon Sep 17 00:00:00 2001 From: Geoff Levand Date: Tue, 13 Jun 2017 13:09:02 -0700 Subject: [PATCH] build-aci: Fix ACI image name The appc discovery spec states that the architecture specifier in the ACI image file name will be an ACI architecture value. Our build scripts were using GOARCH in the image name, which is incorrect for arm64/aarch64. See: https://github.com/appc/spec/blob/master/spec/discovery.md Fixes errors like these on arm64 machines: $ rkt --debug --insecure-options=image fetch coreos.com/etcd:v3.2.0-rc.1 image: remote fetching from URL "https://github.com/coreos/etcd/releases/download/v3.2.0-rc.1/etcd-v3.2.0-rc.1-linux-aarch64.aci" fetch: bad HTTP status code: 404 Signed-off-by: Geoff Levand --- scripts/build-aci | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/build-aci b/scripts/build-aci index b7efb2bccb1..7a4cff93b02 100755 --- a/scripts/build-aci +++ b/scripts/build-aci @@ -36,6 +36,7 @@ fi acbuild --debug begin TMPHOSTS="$(mktemp)" +ACI_ARCH="$(go2aci ${GOARCH})" acbuildEnd() { rm "$TMPHOSTS" @@ -71,7 +72,7 @@ acbuild --debug port add peer tcp 2380 acbuild --debug copy "$TMPHOSTS" /etc/hosts -acbuild --debug label add arch "$(go2aci ${GOARCH})" +acbuild --debug label add arch "${ACI_ARCH}" # mkdir default data-dir mkdir -p .acbuild/currentaci/rootfs/var/lib/etcd @@ -80,4 +81,4 @@ mkdir -p .acbuild/currentaci/rootfs/var/lib/etcd ln -s ./usr/local/bin/etcd .acbuild/currentaci/rootfs/etcd ln -s ./usr/local/bin/etcdctl .acbuild/currentaci/rootfs/etcdctl -acbuild --debug write --overwrite $BUILDDIR/etcd-${1}-linux-${GOARCH}.aci +acbuild --debug write --overwrite $BUILDDIR/etcd-${1}-linux-${ACI_ARCH}.aci