Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop java 8 #1218

Closed
liangyuanpeng opened this issue Sep 6, 2023 · 11 comments · Fixed by #1300
Closed

Drop java 8 #1218

liangyuanpeng opened this issue Sep 6, 2023 · 11 comments · Fixed by #1300
Assignees

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Sep 6, 2023

⚠️ Here is a notification for drop java8 ⚠️

⚠️ jetcd still support run with java8 ⚠️

So far Jetcd still has only one active maintainer, and is active on personal time.

In order to reduce the pressure of maintenance and follow the development of java version, I think it is a good thing that jetcd no longer supports java 8.

Jetcd's maintenance requirements for the java version will likely be LTS-2, it's mean to drop java 8 when after java 21 GA.

The following is the impact on the user list:

✔️ -> No change.
❌ -> Breaking change.

  • apache shardingshpere ✔️
  • apache pulsar ✔️
  • apache shenyu ✔️
  • apache eventmesh ✔️
  • apache dolphinscheduler ✔️
  • apache bookkeeper
  • apache kyuubi ❌
@johnshajiang
Copy link
Contributor

Not sure many jetcd users are watching this project.
You may want to forward this proposal to etcd-dev for wide discussion.

P.S. TLS-2 or LTS-2?

@lburgazzoli
Copy link
Collaborator

P.S. TLS-2 or LTS-2?

fixed

@lburgazzoli
Copy link
Collaborator

@liangyuanpeng will you work on this ?

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Sep 8, 2023

Yes, assign to me please,Thanks.

@tulayang
Copy link

tulayang commented Sep 21, 2023

You've done a very bad thing and wasted a week of my time.

Java 8 or above is required.

Please change this desc.

@johnshajiang
Copy link
Contributor

johnshajiang commented Sep 22, 2023

@tulayang
It also took me some time to investigate why couldn't build this project with JDK 8 ;-)
But currently the jars should still work with all the JDK LTS releases, including 8.

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Sep 22, 2023

@tulayang
Could you please provide more info for it? JEtcd still support run with java8. This just a notification and have not work for it. :)

couldn't build this project with JDK 8 ;-)

This is true, and this does not affect users. check the build log for java8: https://github.com/liangyuanpeng/jetcd/actions/runs/6269397502/job/17025771942

@pan3793
Copy link
Contributor

pan3793 commented Oct 12, 2023

Forward my concern from the Apache Kyuubi community.

Thanks for the information, there is no plan, and not likely to happen in Kyuubi to drop support for Java 8 recently, especially for the client module.

Actually, it's far from Java 8 to reach EOL, as a client library, I suggest the maintainer evaluate the decision of dropping support for Java8 seriously.

https://www.azul.com/products/azul-support-roadmap/

BTW, any specific issues for keeping support for Java8?

@liangyuanpeng
Copy link
Contributor Author

BTW, any specific issues for keeping support for Java8?

#1181 (comment) vvv

I don't think this can last forever as many libraries and tools will at some point drop java 8 support. Also, I'm the only maintainer so I would like to minimize maintenance as much as possible.

@pan3793
Thanks for your feedback, this is important for project development.

Actually, there are not some specific issues for it, Except it is currently not possible to build with java8.

Jetcd depends on vertx-grpc. Currently, vertx-grpc 5.x CI no longer has java8, so may encounter obstacles when upgrading the vertx-grpc component in the future.

This issue just a notification now, I think we will still support java8 for some time to come.

@pan3793
Copy link
Contributor

pan3793 commented Oct 12, 2023

@liangyuanpeng thanks for supplying background, I just leave my concerns from the Apache Kyuubi aspect and it's up to the project maintainer for final decision.

@lburgazzoli
Copy link
Collaborator

Java 8 will be dropped with v0.8.x releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants